feat(module-federation): move common executor logic to module-federation package #29151
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit ca75e46. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 6 targets
Sent with 💌 from NxCloud. |
Coly010
force-pushed
the
module-federation/move-common-executor-utils
branch
from
b9ef5de to
1ce9ecb
Compare
…federation pacakge
…le-federation pacakge
Coly010
force-pushed
the
module-federation/move-common-executor-utils
branch
from
1ce9ecb to
98ad59b
Compare
Coly010
force-pushed
the
module-federation/move-common-executor-utils
branch
from
98ad59b to
ca75e46
Compare
| readProjectsConfigurationFromProjectGraph, | ||
| } from '@nx/devkit'; | ||
|
|
||
| export async function startRemoteIterators( |
There was a problem hiding this comment.
nit: What about just startRemotes, serveRemotes or runRemotes? That's what the function does and the iterators are just an implementation detail.
There was a problem hiding this comment.
It is an impl detail, but I think it makes sense in this case as it indicates that you're getting iterators for both static and dev remotes, which are then combined thereafter.
If we wanted to rename, runRemotes might be the best option, but that can be a cleanup for a different time if we decide on it.
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Current Behavior
The logic for the
module-federation-dev-serverandmodule-federation-ssr-dev-serveris duplicated across Angular, React and Rspack.The majority of this logic is the same, and the duplication causes an increased maintenance tax.
Expected Behavior
Move the logic into a utility that is exposed from
@nx/module-federation.