-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(core): use fork to execute nx generate workspace:preset #29122
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit a03c5fa. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 6 targets
Sent with 💌 from NxCloud. |
🐳 We have a release for that!This PR has a release associated with it. You can try it out using this command: npx [email protected] my-workspace Or just copy this version and use it in your own command: 0.0.0-pr-29122-4727ac1
To request a new release for this pull request, mention someone from the Nx team or the |
4727ac1
to
ef6a0e4
Compare
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Current Behavior
On Windows, when packageManager=pnpm,
create-nx-workspace
fails due to an issue withchild_process.spawn
.Using
spawn
, the@nx/workspace:preset
generator is executed twice whenpackageManager=pnpm
, causing the overall create-nx-workspace flow to fail, even though most things have been set up correctly to that point.Using
fork
has shown success.Expected Behavior
Running
create-nx-workspace --packageManager=pnpm
should work on WindowsFixes
Fixes #20222
Fixes #27270
Fixes #22917
Fixes #22312
Fixes #28710
Fixes #28289
Fixes #28235
Fixes #22383
Fixes #21742
Fixes #20270