Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(rspack): outputHashing should default to 'all' #29011 #29058

Merged
merged 1 commit into from
Nov 25, 2024

Conversation

Coly010
Copy link
Contributor

@Coly010 Coly010 commented Nov 25, 2024

Current Behavior

Current default for outputHashing is set to 'none'.
This means that both executor and plugin usage will output file names that will not bust browser cache.

Expected Behavior

Set default for outputHashing to 'all' to ensure all outputted files are hashed allowing for cache busting.

Related Issue(s)

Fixes #29011

@Coly010 Coly010 requested a review from a team as a code owner November 25, 2024 11:38
@Coly010 Coly010 requested a review from jaysoo November 25, 2024 11:38
Copy link

vercel bot commented Nov 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Nov 25, 2024 11:41am

@Coly010 Coly010 enabled auto-merge (squash) November 25, 2024 13:59
@Coly010 Coly010 merged commit 5f92f17 into master Nov 25, 2024
6 checks passed
@Coly010 Coly010 deleted the rspack/output-hashing-default branch November 25, 2024 14:26
Copy link

github-actions bot commented Dec 1, 2024

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

React / rspack : css file not being hashed
2 participants