Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(core): transition daemon from queue to transaction based messaging #28983

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

feat(core): transition daemon from queue to transaction based messaging #28983

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
55 changes: 1 addition & 54 deletions nx.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,66 +181,13 @@
}
},
"plugins": [
"@monodon/rust",
{
"plugin": "@nx/playwright/plugin",
"options": {
"targetName": "pw-e2e",
"ciTargetName": "e2e-ci"
}
},
{
"plugin": "@nx/eslint/plugin",
"exclude": ["packages/**/__fixtures__/**/*"],
"options": {
"targetName": "lint"
}
},
{
"plugin": "@nx/jest/plugin",
"exclude": [
"e2e/**/*",
"packages/**/__fixtures__/**/*",
"jest.config.ts"
],
"options": {
"targetName": "test"
}
},
{
"plugin": "@nx/webpack/plugin",
"options": {
"serveTargetName": "serve-base",
"buildTargetName": "build-client"
}
},
{
"plugin": "@nx/jest/plugin",
"include": ["e2e/**/*"],
"exclude": ["e2e/detox/**/*", "e2e/react-native/**/*", "e2e/expo/**/*"],
"options": {
"targetName": "e2e-local",
"ciTargetName": "e2e-ci"
}
},
{
"plugin": "@nx/jest/plugin",
"include": ["e2e/detox/**/*", "e2e/react-native/**/*", "e2e/expo/**/*"],
"options": {
"targetName": "e2e-macos-local",
"ciTargetName": "e2e-macos-ci"
}
},
{
"plugin": "@nx/next/plugin",
"options": {
"startTargetName": "next:start",
"buildTargetName": "next:build",
"devTargetName": "dev",
"serveStaticTargetName": "serve-static"
}
},
"@nx/powerpack-enterprise-cloud"
}
],
"nxCloudId": "62d013ea0852fe0a2df74438",
"nxCloudUrl": "https://staging.nx.app",
Expand Down
1 change: 1 addition & 0 deletions packages/angular/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,3 +4,4 @@ export {
optimisticUpdate,
pessimisticUpdate,
} from './src/runtime/nx/data-persistence';
// asda
3 changes: 1 addition & 2 deletions packages/angular/src/plugins/plugin.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,8 +67,6 @@ const knownExecutors = {
test: new Set(['@angular-devkit/build-angular:karma']),
};

const pmc = getPackageManagerCommand();

function readProjectsCache(cachePath: string): Record<string, AngularProjects> {
return existsSync(cachePath) ? readJsonFile(cachePath) : {};
}
Expand Down Expand Up @@ -144,6 +142,7 @@ async function buildAngularProjects(
): Promise<AngularProjects> {
const projects: Record<string, AngularProjects[string] & { root: string }> =
{};
const pmc = getPackageManagerCommand();

const absoluteConfigFilePath = join(context.workspaceRoot, configFilePath);
const angularJson = readJsonFile<AngularJson>(absoluteConfigFilePath);
Expand Down
2 changes: 1 addition & 1 deletion packages/nx/src/command-line/graph/graph.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -560,7 +560,7 @@ async function startServer(
}

if (watchForChanges && daemonClient.enabled()) {
unregisterFileWatcher = await createFileWatcher();
// unregisterFileWatcher = await createFileWatcher();
}

const { projectGraphClientResponse, sourceMapResponse } =
Expand Down
Loading