fix(js): skip tsc batch builds for implicit dependencies #28840
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 5f36e9a. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 4 targets
Sent with 💌 from NxCloud. |
leosvelperez
requested changes
Nov 13, 2024
Implicit dependencies are not referenced in code and therefore TSC incremental builds are not applicable closed nrwl#28839
cogwirrel
force-pushed
the
fix/tsc-batch-implicit-deps
branch
from
8d6a0a0
to
6753e9f
Compare
Thanks so much for the review! I've updated the wording in the docs :) |
FrozenPandaz
pushed a commit
that referenced
this pull request
Nov 14, 2024
Implicit dependencies are not referenced in code and therefore TSC incremental builds are not applicable. ## Current Behavior A project using the `@nx/js:tsc` executor will fail to build if it has implicit dependencies on projects which do not use the `@nx/js:tsc` executor. To reproduce: * Clone https://github.com/cogwirrel/nx-tsc-batch-implicit-deps-example * `pnpm i && pnpm nx run-many --target build --batch --all` ## Expected Behavior - Implicit dependencies that do not use the `@nx/js:tsc` executor are permitted. For example, a TypeScript project may implicitly depend on a Python project, but the TypeScript project should still be buildable in batch mode. - Projects using the `@nx/js:tsc` executor will still fail to build if they have explicit dependencies on projects which do not use the `@nx/js:tsc` executor. Tested by publishing to the local registry, upgrading the [example repo](https://github.com/cogwirrel/nx-tsc-batch-implicit-deps-example) to use my local version, and built successfully in batch mode. ## Related Issue(s) Fixes #28839 (cherry picked from commit e32079c)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implicit dependencies are not referenced in code and therefore TSC incremental builds are not applicable.
Current Behavior
A project using the
@nx/js:tscexecutor will fail to build if it has implicit dependencies on projects which do not use the@nx/js:tscexecutor.To reproduce:
pnpm i && pnpm nx run-many --target build --batch --allExpected Behavior
@nx/js:tscexecutor are permitted. For example, a TypeScript project may implicitly depend on a Python project, but the TypeScript project should still be buildable in batch mode.@nx/js:tscexecutor will still fail to build if they have explicit dependencies on projects which do not use the@nx/js:tscexecutor.Tested by publishing to the local registry, upgrading the example repo to use my local version, and built successfully in batch mode.
Related Issue(s)
Fixes #28839