-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(nx-dev): version picker #28828
feat(nx-dev): version picker #28828
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit a87f7d2. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 4 targets
Sent with 💌 from NxCloud. |
18ee0fd
to
7ea6ae8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple of comments
- can we stay on the same page when switching version? If the page is not available, ideally we'd just go to /docs if possible (it just happens that we version the entire nx.dev website, but it's the docs which is what the user is interested in
- can we backport this to
website-19
etc? otherwise you switch to v19 and there's no version switcher - side-note: having the version switcher in the footer is not really super visible. maybe that was intentional
Cleaned up the code.
|
Adds a version picker to the footer of nx.dev (cherry picked from commit 4540184)
Adds a version picker to the footer of nx.dev
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Adds a version picker to the footer of nx.dev