Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(nx-dev): version picker #28828

Merged
merged 5 commits into from
Nov 14, 2024
Merged

feat(nx-dev): version picker #28828

merged 5 commits into from
Nov 14, 2024

Conversation

isaacplmann
Copy link
Collaborator

Adds a version picker to the footer of nx.dev

@isaacplmann isaacplmann requested a review from a team as a code owner November 7, 2024 03:39
Copy link

vercel bot commented Nov 7, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview Nov 13, 2024 4:59pm

nx-dev/ui-common/src/lib/selector.tsx Outdated Show resolved Hide resolved
nx-dev/ui-common/src/lib/selector.tsx Outdated Show resolved Hide resolved
Copy link
Member

@juristr juristr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of comments

  • can we stay on the same page when switching version? If the page is not available, ideally we'd just go to /docs if possible (it just happens that we version the entire nx.dev website, but it's the docs which is what the user is interested in
  • can we backport this to website-19 etc? otherwise you switch to v19 and there's no version switcher
  • side-note: having the version switcher in the footer is not really super visible. maybe that was intentional

@isaacplmann
Copy link
Collaborator Author

Cleaned up the code.

  • If we stay on the same page when you switch versions, you could get a 404. I updated the link so that it goes to /docs instead.
  • Yes, I can back port it to the older versions after this merges.
  • Yes, the version switcher is intentionally in the footer. It isn't a high frequency action. Once someone knows that its there, they'll just always open the version of the docs that they're on. For most people, it just gets in the way if it is at the top.

@isaacplmann isaacplmann merged commit 4540184 into master Nov 14, 2024
6 checks passed
@isaacplmann isaacplmann deleted the docs/version-picker branch November 14, 2024 15:27
FrozenPandaz pushed a commit that referenced this pull request Nov 15, 2024
Adds a version picker to the footer of nx.dev

(cherry picked from commit 4540184)
nartc pushed a commit that referenced this pull request Nov 15, 2024
Adds a version picker to the footer of nx.dev
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants