Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(nx-cloud): configure import paths for light client when running … #28735

Merged
merged 1 commit into from
Nov 6, 2024

Conversation

lourw
Copy link
Contributor

@lourw lourw commented Oct 31, 2024

…login/logout

Current Behavior

When you call nx login and nx logout, we did not pass in import paths to node modules so the displayed messages for each command were just raw text.

Expected Behavior

When you call login or logout, you get formatting on the command output.

Related Issue(s)

Fixes #

@lourw lourw requested a review from a team as a code owner October 31, 2024 19:31
@lourw lourw requested a review from Cammisuli October 31, 2024 19:31
Copy link

vercel bot commented Oct 31, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Nov 1, 2024 7:51am

@lourw
Copy link
Contributor Author

lourw commented Oct 31, 2024

Screenshot 2024-10-31 at 12 32 24 PM vs Screenshot 2024-10-31 at 12 32 11 PM

@lourw lourw self-assigned this Oct 31, 2024
@lourw lourw force-pushed the lourw/fix-import-paths-for-aliases branch from 62285ba to f3dfc4e Compare October 31, 2024 19:36
@lourw lourw force-pushed the lourw/fix-import-paths-for-aliases branch from f3dfc4e to 4a847bd Compare November 1, 2024 07:48
@lourw lourw merged commit a22a431 into master Nov 6, 2024
6 checks passed
@lourw lourw deleted the lourw/fix-import-paths-for-aliases branch November 6, 2024 21:17
FrozenPandaz pushed a commit that referenced this pull request Nov 6, 2024
#28735)

…login/logout

<!-- Please make sure you have read the submission guidelines before
posting an PR -->
<!--
https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr
-->

<!-- Please make sure that your commit message follows our format -->
<!-- Example: `fix(nx): must begin with lowercase` -->

<!-- If this is a particularly complex change or feature addition, you
can request a dedicated Nx release for this pull request branch. Mention
someone from the Nx team or the `@nrwl/nx-pipelines-reviewers` and they
will confirm if the PR warrants its own release for testing purposes,
and generate it for you if appropriate. -->

## Current Behavior
<!-- This is the behavior we have today -->

When you call `nx login` and `nx logout`, we did not pass in import
paths to node modules so the displayed messages for each command were
just raw text.

## Expected Behavior
<!-- This is the behavior we should expect with the changes in this PR
-->

When you call `login` or `logout`, you get formatting on the command
output.

## Related Issue(s)
<!-- Please link the issue being fixed so it gets closed when this is
merged. -->

Fixes #

(cherry picked from commit a22a431)
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants