Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(angular): use vitest generator instead of vite config generator #28696

Merged
merged 1 commit into from
Oct 30, 2024

Conversation

Coly010
Copy link
Contributor

@Coly010 Coly010 commented Oct 30, 2024

Current Behavior

Using the viteConfigGenerator leads to build and serve targets being overriden

Expected Behavior

Use the vitestGenerator to only add the test target

Related Issue(s)

Fixes #

@Coly010 Coly010 requested a review from a team as a code owner October 30, 2024 12:13
@Coly010 Coly010 self-assigned this Oct 30, 2024
Copy link

vercel bot commented Oct 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Oct 30, 2024 1:36pm

@Coly010 Coly010 enabled auto-merge (squash) October 30, 2024 13:32
@Coly010 Coly010 force-pushed the angular/vitest-unit-test-should-not-override-build branch from 5adf0e2 to f372f00 Compare October 30, 2024 13:33
@yjaaidi
Copy link
Contributor

yjaaidi commented Oct 30, 2024

🙏 Thanks Colum!

@Coly010 Coly010 merged commit c65f344 into master Oct 30, 2024
6 checks passed
@Coly010 Coly010 deleted the angular/vitest-unit-test-should-not-override-build branch October 30, 2024 14:23
Copy link

github-actions bot commented Nov 5, 2024

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants