fix(js): change verdaccio childProcess kill order #28364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit ae1402a. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 4 targets
Sent with 💌 from NxCloud. |
willgm
approved these changes
Oct 8, 2024
himais
approved these changes
Oct 8, 2024
|
Hi @jaysoo Can you help me? |
xiongemi
force-pushed
the
fix/verdaccio-childproccess-kill
branch
from
b31dfe3
to
c7a3814
Compare
xiongemi
approved these changes
Oct 15, 2024
jaysoo
approved these changes
Oct 15, 2024
jaysoo
pushed a commit
that referenced
this pull request
Oct 17, 2024
<!-- Please make sure you have read the submission guidelines before posting an PR --> <!-- https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr --> <!-- Please make sure that your commit message follows our format --> <!-- Example: `fix(nx): must begin with lowercase` --> <!-- If this is a particularly complex change or feature addition, you can request a dedicated Nx release for this pull request branch. Mention someone from the Nx team or the `@nrwl/nx-pipelines-reviewers` and they will confirm if the PR warrants its own release for testing purposes, and generate it for you if appropriate. --> ## Current Behavior `@nx/js:verdaccio` current call `npm config` to setup npm scopes in global `.npmrc` file, which it's supposed to do. However, when process is killed (using terminal exit command or any other way), the process is killed and doesn't restore changed config. In my case I'm changing scope to my private scope (using `scopes` option), but after kill I need to restore manually. ## Expected Behavior When process be killed, restore all configs that was set. ## Related Issue(s) #28353 Fixes #28353
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
@nx/js:verdacciocurrent callnpm configto setup npm scopes in global.npmrcfile, which it's supposed to do.However, when process is killed (using terminal exit command or any other way), the process is killed and doesn't restore changed config.
In my case I'm changing scope to my private scope (using
scopesoption), but after kill I need to restore manually.Expected Behavior
When process be killed, restore all configs that was set.
Related Issue(s)
#28353
Fixes #28353