Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): allow prompts during nx add #28247

Merged
merged 1 commit into from
Oct 2, 2024
Merged

Conversation

jaysoo
Copy link
Member

@jaysoo jaysoo commented Oct 2, 2024

This PR allows nx add to initialize plugins that have prompts.

Current Behavior

Expected Behavior

Related Issue(s)

Fixes #

@jaysoo jaysoo requested a review from a team as a code owner October 2, 2024 16:33
@jaysoo jaysoo requested a review from AgentEnder October 2, 2024 16:33
Copy link

vercel bot commented Oct 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Oct 2, 2024 5:19pm

@jaysoo jaysoo force-pushed the fix/nx-add-prompts branch from b35194e to 9654ec2 Compare October 2, 2024 17:16
@jaysoo jaysoo requested a review from FrozenPandaz October 2, 2024 17:16
@FrozenPandaz FrozenPandaz merged commit e9d8d39 into master Oct 2, 2024
6 checks passed
@FrozenPandaz FrozenPandaz deleted the fix/nx-add-prompts branch October 2, 2024 18:08
FrozenPandaz pushed a commit that referenced this pull request Oct 3, 2024
This PR allows `nx add` to initialize plugins that have prompts.

<!-- If this is a particularly complex change or feature addition, you
can request a dedicated Nx release for this pull request branch. Mention
someone from the Nx team or the `@nrwl/nx-pipelines-reviewers` and they
will confirm if the PR warrants its own release for testing purposes,
and generate it for you if appropriate. -->

## Current Behavior
<!-- This is the behavior we have today -->

## Expected Behavior
<!-- This is the behavior we should expect with the changes in this PR
-->

## Related Issue(s)
<!-- Please link the issue being fixed so it gets closed when this is
merged. -->

Fixes #

(cherry picked from commit e9d8d39)
Copy link

github-actions bot commented Oct 8, 2024

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants