Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(release)!: version.generatorOptions.updateDependents is "auto" by default #28231

Merged
merged 5 commits into from
Oct 2, 2024

Conversation

JamesHenry
Copy link
Collaborator

BREAKING CHANGE

In Nx v19, release.version.generatorOptions.updateDependents is "never" by default, meaning dependents are not automatically patched when their dependencies change (applicable to independent projects).

In Nx v20, release.version.generatorOptions.updateDependents is "auto" by default, meaning dependents are automatically patched when their dependencies change (applicable to independent projects).

Copy link

vercel bot commented Oct 1, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Oct 2, 2024 1:44pm

@JamesHenry JamesHenry marked this pull request as ready for review October 2, 2024 11:43
@JamesHenry JamesHenry requested review from a team as code owners October 2, 2024 11:43
@JamesHenry JamesHenry requested review from xiongemi and jaysoo October 2, 2024 11:43
@@ -494,6 +494,7 @@ To fix this you will either need to add a package.json file at that location, or
currentVersionResolver: 'disk',
specifierSource: 'prompt',
releaseGroup: createReleaseGroup('independent'),
updateDependents: 'auto',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this

@JamesHenry JamesHenry merged commit 6b715ff into master Oct 2, 2024
6 checks passed
@JamesHenry JamesHenry deleted the update-dependents-auto branch October 2, 2024 13:52
Copy link

github-actions bot commented Oct 8, 2024

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants