Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(misc): enable new ts minimal setup by default and guard execution of generators with no support for it #28199

Merged
merged 1 commit into from
Oct 2, 2024

Conversation

leosvelperez
Copy link
Member

@leosvelperez leosvelperez commented Sep 30, 2024

  • Enable generating the new & minimal TS setup by default when generating the ts preset with CNW.
    The existing NX_ADD_TS_PLUGIN environment variable is kept with its default value inverted and set to true. It can be used to opt out of the new TS setup by running CNW with NX_ADD_TS_PLUGIN=false.
  • Throw an error when running generators that don't yet support the new TS setup.
    • We'll add support for those generators incrementally in follow-up PRs.

Current Behavior

Expected Behavior

Related Issue(s)

Fixes #

Copy link

vercel bot commented Sep 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Oct 2, 2024 7:42am

@leosvelperez leosvelperez force-pushed the js/enable-new-ts-setup branch from caf24a2 to bbfad13 Compare October 1, 2024 08:33
@leosvelperez leosvelperez changed the title feat(misc): WIP feat(misc): enable new ts minimal setup by default and guard execution of generators with no support for it Oct 1, 2024
@leosvelperez leosvelperez self-assigned this Oct 1, 2024
@leosvelperez leosvelperez marked this pull request as ready for review October 1, 2024 09:15
@leosvelperez leosvelperez force-pushed the js/enable-new-ts-setup branch from bbfad13 to 2652ec5 Compare October 1, 2024 11:39
@leosvelperez leosvelperez force-pushed the js/enable-new-ts-setup branch from 2652ec5 to f4859bc Compare October 2, 2024 07:39
@jaysoo jaysoo merged commit ec801b4 into master Oct 2, 2024
6 checks passed
@jaysoo jaysoo deleted the js/enable-new-ts-setup branch October 2, 2024 12:29
Copy link

github-actions bot commented Oct 8, 2024

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants