fix(testing): add support for playwright --last-failed #28161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 8555e26. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 4 targets
Sent with 💌 from NxCloud. |
--last-failed allows running only the failed tests from the previous run example: playwright test --last-failed Closes nrwl#28096
agoldis
force-pushed
the
fix/playwright-only-failed
branch
from
a7e9609 to
a1316f4
Compare
leosvelperez
requested changes
Oct 2, 2024
There was a problem hiding this comment.
Thanks for contributing!
There's a mismatch between what the PR describes to do and the change made. The correct option name accepted by Playwright (and mentioned in the PR title and description) is --last-failed, but the changes are adding a failedOnly option.
packages/playwright/src/executors/playwright/playwright.impl.ts
Outdated
Show resolved
Hide resolved
|
@leosvelperez 🤦 my bad... |
|
@leosvelperez thanks for the quick review and the suggestions - it's all fixed now! |
--last-failed allows running only the failed tests from the previous run example: playwright test --last-failed Closes nrwl#28096
agoldis
force-pushed
the
fix/playwright-only-failed
branch
from
0b72e97 to
968c72b
Compare
leosvelperez
approved these changes
Oct 2, 2024
FrozenPandaz
pushed a commit
that referenced
this pull request
Oct 2, 2024
`--last-failed` allows running only the failed tests from the previous run. Example: `playwright test --last-failed`. [Documentation](https://playwright.dev/docs/test-cli#reference) <!-- Please make sure you have read the submission guidelines before posting an PR --> <!-- https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr --> <!-- Please make sure that your commit message follows our format --> <!-- Example: `fix(nx): must begin with lowercase` --> <!-- If this is a particularly complex change or feature addition, you can request a dedicated Nx release for this pull request branch. Mention someone from the Nx team or the `@nrwl/nx-pipelines-reviewers` and they will confirm if the PR warrants its own release for testing purposes, and generate it for you if appropriate. --> ## Current Behavior <!-- This is the behavior we have today --> Cannot provide `--last-failed` flag to playwright ## Expected Behavior <!-- This is the behavior we should expect with the changes in this PR --> Should be able provide `--last-failed` via configuration entry `lastFailed: boolean` ## Related Issue(s) <!-- Please link the issue being fixed so it gets closed when this is merged. --> Fixes #28096 (cherry picked from commit c24292a)
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--last-failedallows running only the failed tests from the previous run.Example:
playwright test --last-failed. DocumentationCurrent Behavior
Cannot provide
--last-failedflag to playwrightExpected Behavior
Should be able provide
--last-failedvia configuration entrylastFailed: booleanRelated Issue(s)
Fixes #28096