Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nx-dev): options of the affected are messed up #28112

Merged
merged 2 commits into from
Sep 26, 2024

Conversation

pawel-twardziak
Copy link
Contributor

Closes #27893

Current Behavior

see #27893

Expected Behavior

see #27893

Related Issue(s)

see #27893

Fixes #

  • docs for affected

Copy link

vercel bot commented Sep 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Sep 26, 2024 11:27am

@isaacplmann
Copy link
Collaborator

You need to run nx documentation and commit the changes that the script creates

@isaacplmann
Copy link
Collaborator

I pushed up a commit after I ran the nx documentation script

@isaacplmann isaacplmann force-pushed the bugs/fix-docs-formatting branch from 9c329aa to 2506d41 Compare September 26, 2024 11:24
@isaacplmann
Copy link
Collaborator

Running the nx documentation script just wiped out all your changes because you were modifying generated files. I found the part of the script that was adding extra new lines and fixed it

@isaacplmann isaacplmann merged commit 4ed8e1e into nrwl:master Sep 26, 2024
6 checks passed
FrozenPandaz pushed a commit that referenced this pull request Sep 26, 2024
Closes #27893

## Current Behavior
see #27893

## Expected Behavior
see #27893

## Related Issue(s)
see #27893

Fixes #
- docs for affected

---------

Co-authored-by: Isaac Mann <[email protected]>
(cherry picked from commit 4ed8e1e)
FrozenPandaz pushed a commit that referenced this pull request Sep 27, 2024
Closes #27893

## Current Behavior
see #27893

## Expected Behavior
see #27893

## Related Issue(s)
see #27893

Fixes #
- docs for affected

---------

Co-authored-by: Isaac Mann <[email protected]>
(cherry picked from commit 4ed8e1e)
@pawel-twardziak
Copy link
Contributor Author

Thanks @isaacplmann, good job! And sorry I was slugginsh a bit...

Copy link

github-actions bot commented Oct 3, 2024

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 3, 2024
@pawel-twardziak pawel-twardziak deleted the bugs/fix-docs-formatting branch November 13, 2024 21:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Affected: The table of options is not formatted properly
2 participants