Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): several powerpack fixes #28088

Merged
merged 1 commit into from
Sep 24, 2024
Merged

fix(core): several powerpack fixes #28088

merged 1 commit into from
Sep 24, 2024

Conversation

FrozenPandaz
Copy link
Collaborator

Current Behavior

  • There is no flag in nx.json to enable the db cache
  • Typings for powerpack are any
  • Powerpack errors are not shown in nx report
  • 9999 workspaces show up when user purchases unlimited license
  • There is no indication from caching that license has expired.

Expected Behavior

  • There is an enableDbCache flag for nx.json. It'll probably be changed soon.
  • Typings for powerpack come from the powerpack packages
  • Powerpack errors are shown in nx report
  • "an unlimited number of workspaces" shows up when user purchases unlimited license
  • There is an indication when licenses expire.

Related Issue(s)

Fixes #

Copy link

vercel bot commented Sep 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview Sep 24, 2024 9:19pm

@FrozenPandaz FrozenPandaz merged commit 4081901 into master Sep 24, 2024
6 checks passed
@FrozenPandaz FrozenPandaz deleted the powerpack-updates2 branch September 24, 2024 22:14
FrozenPandaz added a commit that referenced this pull request Sep 25, 2024
<!-- Please make sure you have read the submission guidelines before
posting an PR -->
<!--
https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr
-->

<!-- Please make sure that your commit message follows our format -->
<!-- Example: `fix(nx): must begin with lowercase` -->

<!-- If this is a particularly complex change or feature addition, you
can request a dedicated Nx release for this pull request branch. Mention
someone from the Nx team or the `@nrwl/nx-pipelines-reviewers` and they
will confirm if the PR warrants its own release for testing purposes,
and generate it for you if appropriate. -->

## Current Behavior
<!-- This is the behavior we have today -->

* There is no flag in `nx.json` to enable the db cache
* Typings for powerpack are `any`
* Powerpack errors are not shown in `nx report`
* 9999 workspaces show up when user purchases unlimited license
* There is no indication from caching that license has expired.

## Expected Behavior
<!-- This is the behavior we should expect with the changes in this PR
-->

* There is an `enableDbCache` flag for `nx.json`. It'll probably be
changed soon.
* Typings for powerpack come from the powerpack packages
* Powerpack errors are shown in nx report
* "an unlimited number of workspaces" shows up when user purchases
unlimited license
* There is an indication when licenses expire.

## Related Issue(s)
<!-- Please link the issue being fixed so it gets closed when this is
merged. -->

Fixes #

(cherry picked from commit 4081901)
Copy link

github-actions bot commented Oct 1, 2024

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants