Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(graph): add spacing between graph details top #28055

Merged
merged 1 commit into from
Sep 26, 2024
Merged

fix(graph): add spacing between graph details top #28055

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions graph/ui-project-details/src/lib/project-details/project-details.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,16 +106,16 @@ export const ProjectDetails = ({
</p>
) : null}
{projectData.tags && projectData.tags.length ? (
<TagList tags={projectData.tags} />
<TagList className="mb-2" tags={projectData.tags} />
) : null}
{projectData.root ? (
<p>
<p className="mb-2">
<span className="font-medium">Root:</span>
<span className="font-mono"> {projectData.root.trim()}</span>
</p>
) : null}
{projectData.projectType ?? typeToProjectType[project.type] ? (
<p>
<p className="mb-2">
<span className="font-medium">Type:</span>
<span className="ml-2 font-mono capitalize">
{projectData.projectType ?? typeToProjectType[project.type]}
Expand Down
6 changes: 4 additions & 2 deletions graph/ui-project-details/src/lib/tag-list/tag-list.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,13 @@
import React, { useState, useRef, useEffect } from 'react';
import { Pill } from '../pill';
import { twMerge } from 'tailwind-merge';

interface TagListProps {
tags: string[];
className: string;
}

export function TagList({ tags }: TagListProps) {
export function TagList({ tags, className }: TagListProps) {
const [isExpanded, _setIsExpanded] = useState(false);
const [isOverflowing, setIsOverflowing] = useState(false);
const tagsContainerRef = useRef<HTMLSpanElement>(null);
Expand Down Expand Up @@ -34,7 +36,7 @@ export function TagList({ tags }: TagListProps) {
}, [tagsContainerRef]);

return (
<div className="relative max-w-full">
<div className={twMerge('relative max-w-full', className)}>
<p className="flex min-w-0 font-medium leading-loose">
<span className="inline-block">Tags:</span>

Expand Down