Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(linter): do not generate docs.recommended property #28009

Merged
merged 1 commit into from
Sep 20, 2024
Merged

fix(linter): do not generate docs.recommended property #28009

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions packages/eslint/src/generators/workspace-rule/__snapshots__/workspace-rule.spec.ts.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,6 @@ export const rule = ESLintUtils.RuleCreator(() => __filename)({
type: 'problem',
docs: {
description: \`\`,
recommended: 'recommended',
},
schema: [],
messages: {},
Expand Down Expand Up @@ -84,7 +83,6 @@ export const rule = ESLintUtils.RuleCreator(() => __filename)({
type: 'problem',
docs: {
description: \`\`,
recommended: 'recommended',
},
schema: [],
messages: {},
Expand Down Expand Up @@ -140,7 +138,6 @@ export const rule = ESLintUtils.RuleCreator(() => __filename)({
type: 'problem',
docs: {
description: \`\`,
recommended: 'recommended',
},
schema: [],
messages: {},
Expand Down
1 change: 0 additions & 1 deletion packages/eslint/src/generators/workspace-rule/files/__name__.ts__tmpl__
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@ export const rule = ESLintUtils.RuleCreator(() => __filename)({
type: 'problem',
docs: {
description: ``,
recommended: 'recommended',
},
schema: [],
messages: {},
Expand Down
1 change: 0 additions & 1 deletion ...s/eslint/src/migrations/update-17-1-0/__snapshots__/update-typescript-eslint.spec.ts.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,6 @@ export const rule = ESLintUtils.RuleCreator(() => __filename)({
type: 'problem',
docs: {
description: \`\`,
recommended: 'recommended',
},
schema: [],
messages: {},
Expand Down
1 change: 0 additions & 1 deletion packages/eslint/src/migrations/update-17-1-0/update-typescript-eslint.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,6 @@ export const rule = ESLintUtils.RuleCreator(() => __filename)({
type: 'problem',
docs: {
description: \`\`,
recommended: 'error',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was an old migration, I don't think it technically matters if it's updated or not?

Copy link
Collaborator Author

@JamesHenry JamesHenry Sep 20, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It didn't ever serve any purpose so it's just setting people up for an issue down the road if they run the migration right now

},
schema: [],
messages: {},
Expand Down