fix(core): nx import detects plugins synchronously #27958
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
jaysoo
force-pushed
the
fix/import-plugins-no-daemon
branch
from
b9bc5bc to
ca6225e
Compare
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 9b57a30. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 4 targets
Sent with 💌 from NxCloud. |
jaysoo
force-pushed
the
fix/import-plugins-no-daemon
branch
from
ca6225e to
83b0d9f
Compare
xiongemi
approved these changes
Sep 17, 2024
jaysoo
force-pushed
the
fix/import-plugins-no-daemon
branch
from
83b0d9f to
c04d72d
Compare
FrozenPandaz
approved these changes
Sep 17, 2024
jaysoo
force-pushed
the
fix/import-plugins-no-daemon
branch
2 times, most recently
from
c0387b3 to
95c8718
Compare
jaysoo
force-pushed
the
fix/import-plugins-no-daemon
branch
from
95c8718 to
9b57a30
Compare
FrozenPandaz
pushed a commit
that referenced
this pull request
Sep 18, 2024
This PR switches `globWithWorkspaceContext` with `globWithWorkspaceContextSync` for `nx init` and `nx import`, since the latter isn't guaranteed to have updated file map during the init/import process. Note: Also updates Gradle import test to ensure the destination repo does not have uncommitted changes. <!-- If this is a particularly complex change or feature addition, you can request a dedicated Nx release for this pull request branch. Mention someone from the Nx team or the `@nrwl/nx-pipelines-reviewers` and they will confirm if the PR warrants its own release for testing purposes, and generate it for you if appropriate. --> ## Current Behavior Sometimes plugins are not detected. ## Expected Behavior Always detect plugins. ## Related Issue(s) <!-- Please link the issue being fixed so it gets closed when this is merged. --> Fixes # (cherry picked from commit eb61254)
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR switches
globWithWorkspaceContextwithglobWithWorkspaceContextSyncfornx initandnx import, since the latter isn't guaranteed to have updated file map during the init/import process.Note: Also updates Gradle import test to ensure the destination repo does not have uncommitted changes.
Current Behavior
Sometimes plugins are not detected.
Expected Behavior
Always detect plugins.
Related Issue(s)
Fixes #