-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(core): import handles argument escaping correctly in Windows #27957
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit a99d5ea. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 4 targets
Sent with 💌 from NxCloud. |
🐳 We have a release for that!This PR has a release associated with it. You can try it out using this command: npx [email protected] my-workspace Or just copy this version and use it in your own command: 0.0.0-pr-27957-7e3588c
To request a new release for this pull request, mention someone from the Nx team or the |
7e3588c
to
1044b72
Compare
1044b72
to
a99d5ea
Compare
🐳 We have a release for that!This PR has a release associated with it. You can try it out using this command: npx [email protected] my-workspace Or just copy this version and use it in your own command: 0.0.0-pr-27957-a99d5ea
To request a new release for this pull request, mention someone from the Nx team or the |
) This PR handles Windows arguments correctly, since Powershell and Cmd do not support single quotes. **Changes:** - Properly escape '\' in Windows paths - Set source and destination using environment variables rather than args to avoid pwsh handling of quotes (cherry picked from commit 91e3ac0)
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
This PR handles Windows arguments correctly, since Powershell and Cmd do not support single quotes.
Changes: