fix(core): respect filenames of inputs when computing task hash #27873
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit b5d0e56. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 4 targets
Sent with 💌 from NxCloud. |
iAmNathanJ
force-pushed
the
fix-native-hash-project-files
branch
2 times, most recently
from
f3ab7c4
to
6fb1fd0
Compare
AgentEnder
requested changes
Sep 11, 2024
iAmNathanJ
force-pushed
the
fix-native-hash-project-files
branch
2 times, most recently
from
e51ac63
to
22510b8
Compare
…uting the hash closed nrwl#23106
iAmNathanJ
force-pushed
the
fix-native-hash-project-files
branch
from
d4c241e
to
b5d0e56
Compare
AgentEnder
approved these changes
Sep 11, 2024
|
@AgentEnder thanks so much. 🙇🏻 |
FrozenPandaz
pushed a commit
that referenced
this pull request
Sep 12, 2024
(cherry picked from commit b6140d4)
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I really don't know if this is the right fix and I'm not a rust programmer. Hoping to get the ball rolling. In our very large scale project, we are hitting invalid cache entries when source files are renamed, which cascades the wrong outputs to dependent targets. 🙏🏻
Current Behavior
When a project file is moved/renamed, the task cache is not invalidated.
Expected Behavior
When a project file is moved/renamed, the task cache is invalidated.
Related Issue(s)
#23106