Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(release): respect updateDependents being explicitly disabled in conventional commits #27851

Merged
merged 1 commit into from
Sep 10, 2024
Merged

fix(release): respect updateDependents being explicitly disabled in conventional commits #27851

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion packages/js/src/generators/release-version/release-version.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -383,7 +383,10 @@ To fix this you will either need to add a package.json file at that location, or
);

if (!specifier) {
if (projectToDependencyBumps.has(projectName)) {
if (
updateDependents !== 'never' &&
projectToDependencyBumps.has(projectName)
) {
// No applicable changes to the project directly by the user, but one or more dependencies have been bumped and updateDependents is enabled
specifier = updateDependentsBump;
logger.buffer(
Expand Down