chore(repo): enable db cache

[FrozenPandaz]

Current Behavior

The new db cache is not being used.

Expected Behavior

The new sqlite db cache is being used.

Related Issue(s)

Fixes #

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment

Name	Status	Preview	Updated (UTC)
nx-dev	⬜️ Ignored (Inspect)	Visit Preview	Sep 9, 2024 9:57pm

[nx-cloud]

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 876e416. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

---

✅ Successfully ran 4 targets

• nx run-many -t check-imports check-commit check-lock-files check-codeowners documentation --parallel=1 --no-dte
• nx affected --targets=lint,test,build,e2e,e2e-ci --base=9b3a96029c9033c0febfcd9b81087f46f5526baa --head=876e416aeb6221d3410cfc871fe6c1e46c37c175 --parallel=3
• nx-cloud record -- nx format:check --base=9b3a96029c9033c0febfcd9b81087f46f5526baa --head=876e416aeb6221d3410cfc871fe6c1e46c37c175
• nx documentation --no-dte

---

Sent with 💌 from NxCloud.

[eliellis]

Hi @FrozenPandaz, watching this work here, and specifically the changes being made to the TaskOrchestrator around the discovery of the internal cache implementation to be used. Based on the code comments, presumably everything will move to the DbCache approach in Nx 21. I am wondering how this will work for those of us currently using our own RemoteCache implementations. Are there any plans to support something similar to the current approach where the defaultTaskRunner accepts a RemoteCache implementation and that propagates into the appropriate slots within the TaskOrchestrator?

Just looking at things right now (which may be in a transitional state, so I'm not sure), it seems like the getCache function, and DbCache implementation (as written) would prevent these custom RemoteCache implementations from functioning given that the check being run is only accounting for circumstances where Nx Cloud is being used, and further on, the _getRemoteCache function returns null for circumstances where Nx Cloud is not being used as well. Would it be possible to continue to propagate these alternative remote cache implementations into the new DbCache implementation from the defaultTasksRunner call as we've previously been able to? Just thinking out loud, but maybe DbCache could be adjusted to take an optional RemoteCacheV2 implementation in its constructor options, and _getRemoteCache could short-circuit if this value has already been set on the DbCache instance?

If need be, I could line up a PR for this if that's something you're interested in. 😊

[github-actions]

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.