Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): fix wasm build #27830

Merged
merged 1 commit into from
Sep 9, 2024
Merged

fix(core): fix wasm build #27830

merged 1 commit into from
Sep 9, 2024

Conversation

FrozenPandaz
Copy link
Collaborator

Current Behavior

wasm build is broken, blocking releases.

Expected Behavior

wasm build is not broken.

Related Issue(s)

Fixes #

@FrozenPandaz FrozenPandaz requested review from a team as code owners September 9, 2024 13:35
Copy link

vercel bot commented Sep 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Sep 9, 2024 1:35pm

@FrozenPandaz FrozenPandaz merged commit d47d41c into master Sep 9, 2024
6 checks passed
@FrozenPandaz FrozenPandaz deleted the fix-wasm branch September 9, 2024 14:25
FrozenPandaz added a commit that referenced this pull request Sep 9, 2024
<!-- Please make sure you have read the submission guidelines before
posting an PR -->
<!--
https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr
-->

<!-- Please make sure that your commit message follows our format -->
<!-- Example: `fix(nx): must begin with lowercase` -->

<!-- If this is a particularly complex change or feature addition, you
can request a dedicated Nx release for this pull request branch. Mention
someone from the Nx team or the `@nrwl/nx-pipelines-reviewers` and they
will confirm if the PR warrants its own release for testing purposes,
and generate it for you if appropriate. -->

<!-- This is the behavior we have today -->

wasm build is broken, blocking releases.

<!-- This is the behavior we should expect with the changes in this PR
-->

wasm build is not broken.

<!-- Please link the issue being fixed so it gets closed when this is
merged. -->

Fixes #

(cherry picked from commit d47d41c)
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants