Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(release): allow string array for commitArgs and tagArgs #27797

Merged
merged 6 commits into from
Sep 17, 2024

Conversation

fahslaj
Copy link
Contributor

@fahslaj fahslaj commented Sep 5, 2024

Allow an array of strings for the "release.git.gitCommitArgs" and "release.git.gitTagArgs" properties, which allow for arguments with spaces to be passed.

Previously, they each needed to be a string and disallowed spaces.

Copy link

vercel bot commented Sep 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Sep 17, 2024 0:27am

@fahslaj fahslaj marked this pull request as ready for review September 6, 2024 22:04
@fahslaj fahslaj requested a review from a team as a code owner September 6, 2024 22:04
@fahslaj fahslaj requested a review from AgentEnder September 6, 2024 22:04
@fahslaj fahslaj requested a review from JamesHenry September 6, 2024 22:04
Copy link
Collaborator

@JamesHenry JamesHenry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please can we update tagArgs for consistency?

@fahslaj fahslaj changed the title fix(release): allow string array for gitCommitArgs fix(release): allow string array for commitArgs and tagArgs Sep 17, 2024
@JamesHenry JamesHenry merged commit 786537e into master Sep 17, 2024
6 checks passed
@JamesHenry JamesHenry deleted the fix/commit-args branch September 17, 2024 10:19
FrozenPandaz pushed a commit that referenced this pull request Sep 18, 2024
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants