Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "feat(core): add shutdown lifecycle hook to node executor" #27794

Merged

Conversation

jaysoo
Copy link
Member

@jaysoo jaysoo commented Sep 5, 2024

Reverts #27354

This patch is causing issues that are more serious than what it fixes.

@jaysoo jaysoo requested a review from a team as a code owner September 5, 2024 16:22
@jaysoo jaysoo requested a review from ndcunningham September 5, 2024 16:22
Copy link

vercel bot commented Sep 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Sep 5, 2024 4:24pm

Copy link

nx-cloud bot commented Sep 5, 2024

@AgentEnder AgentEnder enabled auto-merge (squash) September 6, 2024 14:51
@FrozenPandaz FrozenPandaz merged commit e71e2f3 into master Sep 6, 2024
4 of 6 checks passed
@FrozenPandaz FrozenPandaz deleted the revert-27354-feat/node-executor-shutdown-lifecycle branch September 6, 2024 14:55
FrozenPandaz pushed a commit that referenced this pull request Sep 6, 2024
…7794)

Reverts #27354

This patch is causing issues that are more serious than what it fixes.

(cherry picked from commit e71e2f3)
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants