Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(graph): enable composite graph functionality #27789

Merged
merged 8 commits into from
Sep 25, 2024
Merged

Conversation

nartc
Copy link
Contributor

@nartc nartc commented Sep 5, 2024

This PR enables composite graph functionality:

  • Experimental feature to enable Composite Graph
  • In Composite Graph mode:
    • Nodes are shown by default.
    • Show/Hide All Projects function similarly to regular mode
    • Focus a Composite Node renders the inner nodes with up-to 3 additional containers: Green area contains external nodes that depend on the inner nodes; Orange area contains external nodes that the inner nodes depend depend on; Purple area contains external nodes with circular dependencies with the inner nodes.
      • Focused node can be unfocus/reset.
      • Only one node can be focused at one given time. - Show All projects while having a focused node will unfocus the node.
    • Expand a Composite Node renders the inner nodes of the composite node in-place (i.e: still keep the context of the current graph). Expanded node can be collapsed to go back.

Copy link

vercel bot commented Sep 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview Sep 24, 2024 8:51pm

@nartc nartc self-assigned this Sep 5, 2024
@nartc nartc force-pushed the feat/composite-graph branch from fd402a5 to e8994df Compare September 10, 2024 21:52
@MaxKless
Copy link
Collaborator

Found an error:
image

steps to repro:

  • nx run graph-client:serve
  • focus on packages composite view
  • exclude ./e2e
  • exclude ./packages-legacy
  • try to expand ./tools
  • -> see error

This PR enables composite graph functionality:
- Experimental feature to enable Composite Graph
- In Composite Graph mode:
  - Nodes are shown by default.
  - Show/Hide All Projects function similarly to regular mode
  - Focus a Composite Node renders the inner nodes with up-to 3
additional containers: Green area contains external nodes that depend on
the inner nodes; Orange area contains external nodes that the inner
nodes depend depend on; Purple area contains external nodes with
circular dependencies with the inner nodes.
    - Focused node can be unfocus/reset.
    - Only one node can be focused at one given time.
    - Show All projects while having a focused node will unfocus the
node.
  - Expand a Composite Node renders the inner nodes of the composite
node in-place (i.e: still keep the context of the current graph).
Expanded node can be collapsed to go back.
@jaysoo jaysoo merged commit 3c95965 into master Sep 25, 2024
6 checks passed
@jaysoo jaysoo deleted the feat/composite-graph branch September 25, 2024 17:20
Copy link

github-actions bot commented Oct 1, 2024

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants