-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(release): support forwarding the --access flag to npm publish #27765
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit da97eb3. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 4 targets
Sent with 💌 from NxCloud. |
// Hidden for now until the feature is more stable | ||
describe: false, | ||
describe: | ||
'Create a version plan file to specify the desired semver bump for one or more projects or groups, as well as the relevant changelog entry', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor: descriptions should end with a .
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was matching the existing commands in there, looks like we are pretty inconsistent in general. We should add a custom lint rule for this like we did for schema descriptions.
// Create a plan to pick a new version and generate a changelog entry. | ||
// Hidden for now until the feature is more stable | ||
describe: false, | ||
describe: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here, add .
at the end.
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Current Behavior
The
access
option ofnpm publish
is configurable viapackage.json
publishConfig
or environment variable.Expected Behavior
The
access
option ofnpm publish
is configurable viapackage.json
publishConfig
, environment variable, or a--access
option onnx release publish
.Related Issue(s)
Fixes #27754
Additionally, when generating the docs for the new flag, I realized I never went back and exposed
release plan
andrelease plan:check
in the docs, so I did that here too.