Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(release): support forwarding the --access flag to npm publish #27765

Merged
merged 1 commit into from
Sep 4, 2024

Conversation

JamesHenry
Copy link
Collaborator

@JamesHenry JamesHenry commented Sep 4, 2024

Current Behavior

The access option of npm publish is configurable via package.json publishConfig or environment variable.

Expected Behavior

The access option of npm publish is configurable via package.json publishConfig, environment variable, or a --access option on nx release publish.

Related Issue(s)

Fixes #27754


Additionally, when generating the docs for the new flag, I realized I never went back and exposed release plan and release plan:check in the docs, so I did that here too.

Copy link

vercel bot commented Sep 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview Sep 4, 2024 1:10pm

@JamesHenry JamesHenry marked this pull request as ready for review September 4, 2024 13:04
@JamesHenry JamesHenry requested review from a team as code owners September 4, 2024 13:04
@JamesHenry JamesHenry enabled auto-merge (squash) September 4, 2024 13:04
// Hidden for now until the feature is more stable
describe: false,
describe:
'Create a version plan file to specify the desired semver bump for one or more projects or groups, as well as the relevant changelog entry',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor: descriptions should end with a ..

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was matching the existing commands in there, looks like we are pretty inconsistent in general. We should add a custom lint rule for this like we did for schema descriptions.

// Create a plan to pick a new version and generate a changelog entry.
// Hidden for now until the feature is more stable
describe: false,
describe:
Copy link
Member

@jaysoo jaysoo Sep 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here, add . at the end.

@JamesHenry JamesHenry disabled auto-merge September 4, 2024 13:57
@JamesHenry JamesHenry enabled auto-merge (squash) September 4, 2024 13:57
@JamesHenry JamesHenry disabled auto-merge September 4, 2024 13:58
@JamesHenry JamesHenry merged commit 1108ebf into master Sep 4, 2024
6 checks passed
@JamesHenry JamesHenry deleted the js-publish-access branch September 4, 2024 13:58
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't generate provenance for new or private package, you must set access to public.
3 participants