Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): change remoteCache to getRemoteCache #27673

Merged
merged 1 commit into from
Aug 28, 2024

Conversation

Cammisuli
Copy link
Member

@Cammisuli Cammisuli commented Aug 28, 2024

Current Behavior

Calling remoteCache directly for the Nx cloud package causes issues with how nx cloud deals with imports

Expected Behavior

remoteCache is now a function call so that the nx cloud package functions properly

Related Issue(s)

Fixes #

@Cammisuli Cammisuli requested a review from a team as a code owner August 28, 2024 12:46
@Cammisuli Cammisuli requested a review from AgentEnder August 28, 2024 12:46
Copy link

vercel bot commented Aug 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Aug 28, 2024 1:21pm

@Cammisuli Cammisuli force-pushed the update-remote-cache-retrieval branch from 0247575 to 50ef9f4 Compare August 28, 2024 13:18
@Cammisuli Cammisuli changed the title fix(core): change remoteCache to be a function call fix(core): change remoteCache to getRemoteCache Aug 28, 2024
@FrozenPandaz FrozenPandaz merged commit a0dc0f1 into master Aug 28, 2024
6 checks passed
@FrozenPandaz FrozenPandaz deleted the update-remote-cache-retrieval branch August 28, 2024 14:25
Copy link

github-actions bot commented Sep 3, 2024

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants