feat(core): add metagenerator for convert-to-inferred #27672
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 2b8154d. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 5 targets
Sent with 💌 from NxCloud. |
MaxKless
force-pushed
the
cvi-metagenerator
branch
from
fc9d7e8 to
e7431fc
Compare
MaxKless
force-pushed
the
cvi-metagenerator
branch
from
e7431fc to
6e066d7
Compare
MaxKless
requested review from
FrozenPandaz,
jaysoo,
AgentEnder,
a team and
Coly010
as code owners
Coly010
approved these changes
Aug 30, 2024
isaacplmann
approved these changes
Aug 30, 2024
jaysoo
reviewed
Sep 9, 2024
packages/workspace/src/generators/infer-targets/infer-targets.ts
Outdated
Show resolved
Hide resolved
packages/workspace/src/generators/infer-targets/infer-targets.ts
Outdated
Show resolved
Hide resolved
MaxKless
force-pushed
the
cvi-metagenerator
branch
from
0c910eb to
5ab7f1f
Compare
jaysoo
approved these changes
Sep 12, 2024
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
The DX to migrate to project crystal isn't great right now - people have to run
convert-to-inferredgenerators manually.Expected Behavior
We should provide a smoother way to migrate, so we introduced an
@nx/workspace:infer-targetsgenerator that can handle multiple conversions at once, either for the whole workspace or at a project level.