Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): return task results from imperative task runner #27640

Merged
merged 1 commit into from
Aug 26, 2024

Conversation

FrozenPandaz
Copy link
Collaborator

Current Behavior

Imperatively running tasks does not return task results.

Expected Behavior

Imperatively running tasks returns task results along with the overall status and the task graph

Related Issue(s)

Fixes #

@FrozenPandaz FrozenPandaz requested a review from a team as a code owner August 26, 2024 19:25
@FrozenPandaz FrozenPandaz requested a review from xiongemi August 26, 2024 19:25
Copy link

vercel bot commented Aug 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Aug 26, 2024 7:51pm

Copy link

Failed to publish a PR release of this pull request, triggered by @FrozenPandaz.
See the failed workflow run at: https://github.com/nrwl/nx/actions/runs/10566101884

Copy link

🐳 We have a release for that!

This PR has a release associated with it. You can try it out using this command:

npx [email protected] my-workspace

Or just copy this version and use it in your own command:

0.0.0-pr-27640-2822b72
Release details 📑
Published version 0.0.0-pr-27640-2822b72
Triggered by @FrozenPandaz
Branch add-task-results
Commit 2822b72
Workflow run 10566257832

To request a new release for this pull request, mention someone from the Nx team or the @nrwl/nx-pipelines-reviewers.

@FrozenPandaz FrozenPandaz merged commit 6fff9b5 into master Aug 26, 2024
6 checks passed
@FrozenPandaz FrozenPandaz deleted the add-task-results branch August 26, 2024 20:54
FrozenPandaz added a commit that referenced this pull request Aug 28, 2024
## Current Behavior
<!-- This is the behavior we have today -->

Imperatively running tasks does not return task results.

## Expected Behavior
<!-- This is the behavior we should expect with the changes in this PR
-->

Imperatively running tasks returns task results along with the overall
status and the task graph

## Related Issue(s)
<!-- Please link the issue being fixed so it gets closed when this is
merged. -->

Fixes #

(cherry picked from commit 6fff9b5)
Copy link

github-actions bot commented Sep 1, 2024

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants