Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(repo): use nx cloud id for auth #27546

Merged
merged 1 commit into from
Aug 20, 2024
Merged

Conversation

lourw
Copy link
Contributor

@lourw lourw commented Aug 20, 2024

Current Behavior

Nx Cloud uses the nxCloudAccessToken to authenticate and provide permissions access the cache.

Expected Behavior

Users who want to use Nx Cloud locally with a read-write token will need to run nx-cloud login to generate a personal access token and have nxCloudId in their nx.json. These two pieces of identification are needed together to provide permissions to access nx cloud features.

By default users who do not have a personal access token/do not have an Nx Cloud account will have 'read' permissions.

Related Issue(s)

Fixes #

Copy link

vercel bot commented Aug 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview Aug 20, 2024 4:40pm

@lourw lourw marked this pull request as ready for review August 20, 2024 16:33
@lourw lourw merged commit 2065033 into master Aug 20, 2024
6 checks passed
@lourw lourw deleted the lourw/use-nx-cloud-login branch August 20, 2024 21:38
FrozenPandaz pushed a commit that referenced this pull request Aug 21, 2024
<!-- Please make sure you have read the submission guidelines before
posting an PR -->
<!--
https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr
-->

<!-- Please make sure that your commit message follows our format -->
<!-- Example: `fix(nx): must begin with lowercase` -->

<!-- If this is a particularly complex change or feature addition, you
can request a dedicated Nx release for this pull request branch. Mention
someone from the Nx team or the `@nrwl/nx-pipelines-reviewers` and they
will confirm if the PR warrants its own release for testing purposes,
and generate it for you if appropriate. -->

## Current Behavior
<!-- This is the behavior we have today -->

Nx Cloud uses the nxCloudAccessToken to authenticate and provide
permissions access the cache.

## Expected Behavior
<!-- This is the behavior we should expect with the changes in this PR
-->

Users who want to use Nx Cloud locally with a read-write token will need
to run `nx-cloud login` to generate a personal access token and have
`nxCloudId` in their nx.json. These two pieces of identification are
needed together to provide permissions to access nx cloud features.

By default users who do not have a personal access token/do not have an
Nx Cloud account will have 'read' permissions.

## Related Issue(s)
<!-- Please link the issue being fixed so it gets closed when this is
merged. -->

Fixes #

(cherry picked from commit 2065033)
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants