Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(js): only sync references when composite is true, preserve comments in other parts of file #27530

Merged
merged 9 commits into from
Aug 20, 2024
Merged

fix(js): only sync references when composite is true, preserve comments in other parts of file #27530

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
e9b78b1
fix(js): preserve comments when patching references
JamesHenry Aug 19, 2024
79d84ed
chore(js): add composite: true to test compilerOptions
JamesHenry Aug 19, 2024
cb05657
fix(js): check for composite: true during syncing
JamesHenry Aug 19, 2024
ad48628
chore(js): format
JamesHenry Aug 19, 2024
ac0b567
fix(js): add coverage for when composite is not true
JamesHenry Aug 20, 2024
188f4ac
chore(js): add cache for tsconfig composite lookups
JamesHenry Aug 20, 2024
db566c6
Merge branch 'master' into typescript-sync-fixes
JamesHenry Aug 20, 2024
4059102
chore(js): cache all fs operations
JamesHenry Aug 20, 2024
bb0f3ec
chore(js): apply suggestions from code review
JamesHenry Aug 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 9 additions & 8 deletions packages/js/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,11 +34,13 @@
"dependencies": {
"@babel/core": "^7.23.2",
"@babel/plugin-proposal-decorators": "^7.22.7",
"@babel/plugin-transform-runtime": "^7.23.2",
"@babel/plugin-transform-class-properties": "^7.22.5",
"@babel/plugin-transform-runtime": "^7.23.2",
"@babel/preset-env": "^7.23.2",
"@babel/preset-typescript": "^7.22.5",
"@babel/runtime": "^7.22.6",
"@nx/devkit": "file:../devkit",
"@nx/workspace": "file:../workspace",
"babel-plugin-const-enum": "^1.0.1",
"babel-plugin-macros": "^2.8.0",
"babel-plugin-transform-typescript-metadata": "^0.3.1",
Expand All @@ -47,19 +49,18 @@
"detect-port": "^1.5.1",
"fast-glob": "3.2.7",
"fs-extra": "^11.1.0",
"npm-package-arg": "11.0.1",
"npm-run-path": "^4.0.1",
"ts-node": "10.9.1",
"tsconfig-paths": "^4.1.2",
"ignore": "^5.0.4",
"js-tokens": "^4.0.0",
"jsonc-parser": "3.2.0",
"minimatch": "9.0.3",
"npm-package-arg": "11.0.1",
"npm-run-path": "^4.0.1",
"ora": "5.3.0",
"semver": "^7.5.3",
"source-map-support": "0.5.19",
"tslib": "^2.3.0",
"@nx/devkit": "file:../devkit",
"@nx/workspace": "file:../workspace"
"ts-node": "10.9.1",
"tsconfig-paths": "^4.1.2",
"tslib": "^2.3.0"
},
"peerDependencies": {
"verdaccio": "^5.0.4"
Expand Down
Loading