fix(react): assert test property is defined on webpack rule in nx-react-webpack-plugin #27525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit a0f2358. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 6 targets
Sent with 💌 from NxCloud. |
|
Hey @ndcunningham - hope you're doing well. Not sure how big your backlog is atm—just wondering if you'd had a chance to peek at this yet? |
FrozenPandaz
changed the title
…-react-webpack-plugin The `removeSvgLoaderIfPresent` method in `apply-react-config.ts` iterates through each Webpack rule, calls `toString` on each `test` property, and checks for the presence of the string `"svg"` to see if any existing SVG plugins need to be removed. Some of the Webpack rules in the config don't have the test property, and calling `toString` without asserting the test property is defined first throws type errors. This commit introduces a very small change that simply asserts that `rule.test` is not `undefined` before calling `.toString()`.
Coly010
approved these changes
Dec 11, 2024
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
removeSvgLoaderIfPresentmethod inapply-react-config.tsiterates through each Webpack rule, callstoStringon eachtestproperty, and checks for the presence of the string"svg"to see if any existing SVG plugins need to be removed.Some of the Webpack rules in the config don't have the test property, and calling
toStringwithout asserting the test property is defined first throws type errors.This commit introduces a very small change that simply asserts that
rule.testis notundefinedbefore calling.toString().Current Behavior
Running a React Webpack library with
svgrenabled causes compilation errors.Expected Behavior
Enabling SVGR in the
NxReactWebpackPluginconfig should compile as normal.Related Issue(s)
N/A