Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): negative workspace-root filesets should override positive filesets #27524

Merged
merged 3 commits into from
Aug 26, 2024

Conversation

AgentEnder
Copy link
Member

…filesets

Current Behavior

If a project has an input that references multiple named inputs, and one of those named inputs excludes a workspace file that was included by the other, the file is still included.

Expected Behavior

Excludes take preference

Related Issue(s)

Fixes #

@AgentEnder AgentEnder requested review from a team as code owners August 19, 2024 22:10
Copy link

vercel bot commented Aug 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Aug 26, 2024 9:14pm

@AgentEnder AgentEnder force-pushed the fix/tasks-hasher-workspace-files branch from f597e34 to 965d83b Compare August 23, 2024 19:32
@AgentEnder AgentEnder force-pushed the fix/tasks-hasher-workspace-files branch from 965d83b to 46a60f3 Compare August 26, 2024 16:39
@AgentEnder AgentEnder force-pushed the fix/tasks-hasher-workspace-files branch from 46a60f3 to ce1242f Compare August 26, 2024 21:11
@AgentEnder AgentEnder merged commit 61ecd4b into master Aug 26, 2024
6 checks passed
@AgentEnder AgentEnder deleted the fix/tasks-hasher-workspace-files branch August 26, 2024 22:28
FrozenPandaz pushed a commit that referenced this pull request Aug 28, 2024
Copy link

github-actions bot commented Sep 1, 2024

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants