Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nextjs): should not fail when running outside of nx cli #27523

Merged
merged 1 commit into from
Aug 20, 2024

Conversation

ndcunningham
Copy link
Contributor

fixes: #22450

Current Behavior

Currently, if you run any next target outside of nx the build will fail because we only fallback for graph creation of if running prod server.

Expected Behavior

Targets should work if they are run outside of the Nx cli

Related Issue(s)

Fixes #

@ndcunningham ndcunningham added the scope: nextjs Issues related to NextJS support for Nx label Aug 19, 2024
@ndcunningham ndcunningham self-assigned this Aug 19, 2024
@ndcunningham ndcunningham requested a review from a team as a code owner August 19, 2024 21:35
@ndcunningham ndcunningham requested a review from mandarini August 19, 2024 21:35
Copy link

vercel bot commented Aug 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Aug 19, 2024 9:35pm

@ndcunningham ndcunningham merged commit 31c5745 into master Aug 20, 2024
7 checks passed
@ndcunningham ndcunningham deleted the fix/next-with-nx-outside-of-nx branch August 20, 2024 17:43
FrozenPandaz pushed a commit that referenced this pull request Aug 21, 2024
fixes: #22450

<!-- Please make sure you have read the submission guidelines before
posting an PR -->
<!--
https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr
-->

<!-- Please make sure that your commit message follows our format -->
<!-- Example: `fix(nx): must begin with lowercase` -->

<!-- If this is a particularly complex change or feature addition, you
can request a dedicated Nx release for this pull request branch. Mention
someone from the Nx team or the `@nrwl/nx-pipelines-reviewers` and they
will confirm if the PR warrants its own release for testing purposes,
and generate it for you if appropriate. -->

## Current Behavior
<!-- This is the behavior we have today -->
Currently, if you run any next target outside of nx the build will fail
because we only fallback for graph creation of if running prod server.

## Expected Behavior
<!-- This is the behavior we should expect with the changes in this PR
-->
Targets should work if they are run outside of the Nx cli

## Related Issue(s)
<!-- Please link the issue being fixed so it gets closed when this is
merged. -->

Fixes #

(cherry picked from commit 31c5745)
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
scope: nextjs Issues related to NextJS support for Nx
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to run load nextjs jest config outside of nx run
2 participants