Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(misc): ensure custom reporters are usable with @nx/playwright:playwright #27443

Merged
merged 2 commits into from
Aug 15, 2024

Conversation

EGonz1PCTY
Copy link
Contributor

@EGonz1PCTY EGonz1PCTY commented Aug 14, 2024

Current Behavior

Custom reporters are not usable because we enforce an enum on the schema

Expected Behavior

Custom reporters can be specified

Related Issue(s)

Fixes #

@EGonz1PCTY EGonz1PCTY requested a review from a team as a code owner August 14, 2024 18:59
Copy link

vercel bot commented Aug 14, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview Aug 15, 2024 0:35am

@EGonz1PCTY EGonz1PCTY force-pushed the Playwright_Reporter_Update branch from f1c595a to a5056a6 Compare August 14, 2024 18:59
@AgentEnder AgentEnder requested a review from a team as a code owner August 14, 2024 19:05
@AgentEnder AgentEnder requested a review from isaacplmann August 14, 2024 19:05
@AgentEnder AgentEnder changed the title fix(misc): removed Enum from playwright json schema and reworded desc… fix(misc): ensure custom reporters are usable with @nx/playwright:playwright Aug 14, 2024
@EGonz1PCTY EGonz1PCTY force-pushed the Playwright_Reporter_Update branch from 6c91c93 to 5925cd7 Compare August 15, 2024 12:25
@AgentEnder AgentEnder merged commit 8c7e361 into nrwl:master Aug 15, 2024
6 checks passed
FrozenPandaz pushed a commit that referenced this pull request Aug 19, 2024
…ywright (#27443)

<!-- Please make sure you have read the submission guidelines before
posting an PR -->
<!--
https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr
-->

<!-- Please make sure that your commit message follows our format -->
<!-- Example: `fix(nx): must begin with lowercase` -->

<!-- If this is a particularly complex change or feature addition, you
can request a dedicated Nx release for this pull request branch. Mention
someone from the Nx team or the `@nrwl/nx-pipelines-reviewers` and they
will confirm if the PR warrants its own release for testing purposes,
and generate it for you if appropriate. -->

## Current Behavior
Custom reporters are not usable because we enforce an enum on the schema

## Expected Behavior
Custom reporters can be specified

## Related Issue(s)
<!-- Please link the issue being fixed so it gets closed when this is
merged. -->

Fixes #

---------

Co-authored-by: Craigory Coppola <[email protected]>
(cherry picked from commit 8c7e361)
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants