Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(testing): migrations should look for existing target before attempting migration #27441

Merged
merged 1 commit into from
Aug 14, 2024

Conversation

Coly010
Copy link
Contributor

@Coly010 Coly010 commented Aug 14, 2024

Current Behavior

Migrations are naively setting serve-static or preview as the target without checking if that target exists

Expected Behavior

Check if the target exists based on executor usage as a last port of call, and use the name of the target it is found on

Related Issue(s)

Closes #27439

@Coly010 Coly010 requested a review from a team as a code owner August 14, 2024 18:30
@Coly010 Coly010 requested a review from jaysoo August 14, 2024 18:30
@Coly010 Coly010 self-assigned this Aug 14, 2024
Copy link

vercel bot commented Aug 14, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Aug 14, 2024 6:33pm

@FrozenPandaz FrozenPandaz merged commit 3d7f60a into master Aug 14, 2024
6 checks passed
@FrozenPandaz FrozenPandaz deleted the testing/e2e-ci-migration-fixes branch August 14, 2024 19:14
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants