Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(testing): cypress update ci webserver to serve-static based on plugins #27399

Merged
merged 1 commit into from
Aug 13, 2024

Conversation

Coly010
Copy link
Contributor

@Coly010 Coly010 commented Aug 13, 2024

Current Behavior

We're only checking for Vite and adding preview as a string on its own when running the migration to update cypress.config.ts ciWebServerCommand

Expected Behavior

Check both Vite and Webpack and update according to plugin if one exists

Related Issue(s)

Fixes #

@Coly010 Coly010 requested a review from a team as a code owner August 13, 2024 09:21
@Coly010 Coly010 self-assigned this Aug 13, 2024
@Coly010 Coly010 requested a review from FrozenPandaz August 13, 2024 09:21
Copy link

vercel bot commented Aug 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Aug 13, 2024 9:23am

@Coly010 Coly010 merged commit 28a0bb3 into master Aug 13, 2024
6 checks passed
@Coly010 Coly010 deleted the cypress/ci-webserver-migration-fix branch August 13, 2024 12:16
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants