Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(webpack): return proper webpack plugin from useLegacyNxPlugin function #27340

Merged
merged 1 commit into from
Aug 8, 2024

Conversation

jaysoo
Copy link
Member

@jaysoo jaysoo commented Aug 8, 2024

The current useLegacyNxPlugin has two issues:

  1. It doesn't pass the configuration object, but rather the compiler instance.
  2. It doesn't handle async correctly

This PR resolves both issues.

Current Behavior

Legacy plugins don't actually work.

Expected Behavior

Legacy plugins work.

Related Issue(s)

Fixes #

Copy link

vercel bot commented Aug 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Aug 8, 2024 2:41pm

@jaysoo jaysoo marked this pull request as ready for review August 8, 2024 14:40
@jaysoo jaysoo requested a review from a team as a code owner August 8, 2024 14:40
@jaysoo jaysoo requested a review from mandarini August 8, 2024 14:40
@jaysoo jaysoo merged commit 712dbbc into master Aug 8, 2024
6 checks passed
@jaysoo jaysoo deleted the fix/webpack-legacy-plugins branch August 8, 2024 15:29
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants