-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(testing): support positional arg for jest executor #27328
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit b75a74a. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 4 targets
Sent with 💌 from NxCloud. |
Run |
41f5688
to
a9ccc6d
Compare
a9ccc6d
to
84c397c
Compare
I see this error now in CI 🤔 |
@MJez29 It was an issue on an older version of master, I've just pulled in the latest for you |
04c24f3
to
46c3276
Compare
@isaacplmann @JamesHenry how can I resolve the CI failure now? It looks like a timeout to me |
46c3276
to
b8c9d46
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I missed this in my previous review. One last small thing left, and it should be good to go 🚀
b8c9d46
to
b75a74a
Compare
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Current Behavior
The syntax to test a single file is different when using the jest executor versus the jest cli
Expected Behavior
I would expect the jest executor to support a single positional argument as well
This is one of the common questions/complaints that I hear from developers when transitioning from our standalone apps to our monorepo
This change supports both syntaxes so that this is not a breaking change and prints a warning when both are used