fix(core): don't cache full dependency configuration when expanding target name #27308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AgentEnder
requested review from
a team,
FrozenPandaz and
vsavkin
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 5af41ac. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 4 targets
Sent with 💌 from NxCloud. |
AgentEnder
force-pushed
the
dependson-fixes-and-tests
branch
from
eeb6803 to
5af41ac
Compare
FrozenPandaz
approved these changes
Aug 6, 2024
FrozenPandaz
pushed a commit
that referenced
this pull request
Aug 7, 2024
…arget name (#27308) <!-- Please make sure you have read the submission guidelines before posting an PR --> <!-- https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr --> <!-- Please make sure that your commit message follows our format --> <!-- Example: `fix(nx): must begin with lowercase` --> <!-- If this is a particularly complex change or feature addition, you can request a dedicated Nx release for this pull request branch. Mention someone from the Nx team or the `@nrwl/nx-pipelines-reviewers` and they will confirm if the PR warrants its own release for testing purposes, and generate it for you if appropriate. --> ## Current Behavior There is a cache that maps target pattern -> dependency configuration, but the dependency configuration contains more than just the target name. This results in retrieving cached dependency configurations that contain the wrong projects to run. ## Expected Behavior The cache maps target pattern -> target names, which we can then map to the full dependency configuration with the extra info we know. ## Related Issue(s) <!-- Please link the issue being fixed so it gets closed when this is merged. --> Fixes # (cherry picked from commit 26f46c2)
ZackDeRose
pushed a commit
to ZackDeRose/nx
that referenced
this pull request
Aug 8, 2024
…arget name (nrwl#27308) <!-- Please make sure you have read the submission guidelines before posting an PR --> <!-- https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr --> <!-- Please make sure that your commit message follows our format --> <!-- Example: `fix(nx): must begin with lowercase` --> <!-- If this is a particularly complex change or feature addition, you can request a dedicated Nx release for this pull request branch. Mention someone from the Nx team or the `@nrwl/nx-pipelines-reviewers` and they will confirm if the PR warrants its own release for testing purposes, and generate it for you if appropriate. --> ## Current Behavior There is a cache that maps target pattern -> dependency configuration, but the dependency configuration contains more than just the target name. This results in retrieving cached dependency configurations that contain the wrong projects to run. ## Expected Behavior The cache maps target pattern -> target names, which we can then map to the full dependency configuration with the extra info we know. ## Related Issue(s) <!-- Please link the issue being fixed so it gets closed when this is merged. --> Fixes #
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
There is a cache that maps target pattern -> dependency configuration, but the dependency configuration contains more than just the target name. This results in retrieving cached dependency configurations that contain the wrong projects to run.
Expected Behavior
The cache maps target pattern -> target names, which we can then map to the full dependency configuration with the extra info we know.
Related Issue(s)
Fixes #