fix(testing): e2e-ci should use serve-static or vite preview for playwright and cypress #27240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 0962161. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 5 targets
Sent with 💌 from NxCloud. |
Coly010
force-pushed
the
playwright/perview-for-cypress
branch
from
fdbc457 to
203d902
Compare
FrozenPandaz
requested changes
Jul 31, 2024
|
Playwright can also use ‘serve-static’ instead of ‘serve’ |
Coly010
changed the title
Coly010
force-pushed
the
playwright/perview-for-cypress
branch
from
28be2db to
0a120b4
Compare
FrozenPandaz
approved these changes
Aug 1, 2024
FrozenPandaz
approved these changes
Aug 1, 2024
Coly010
force-pushed
the
playwright/perview-for-cypress
branch
from
18c45c3 to
774361f
Compare
FrozenPandaz
approved these changes
Aug 2, 2024
Coly010
force-pushed
the
playwright/perview-for-cypress
branch
from
774361f to
08600fe
Compare
Coly010
force-pushed
the
playwright/perview-for-cypress
branch
from
08600fe to
0962161
Compare
ZackDeRose
pushed a commit
to ZackDeRose/nx
that referenced
this pull request
Aug 8, 2024
…ywright and cypress (nrwl#27240) - fix(vite): preview should dependOn build - fix(react): playwright should use vite preview - fix(vue): playwright should use vite preview - fix(web): playwright should use vite preview - chore(testing): add e2e test <!-- Please make sure you have read the submission guidelines before posting an PR --> <!-- https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr --> <!-- Please make sure that your commit message follows our format --> <!-- Example: `fix(nx): must begin with lowercase` --> <!-- If this is a particularly complex change or feature addition, you can request a dedicated Nx release for this pull request branch. Mention someone from the Nx team or the `@nrwl/nx-pipelines-reviewers` and they will confirm if the PR warrants its own release for testing purposes, and generate it for you if appropriate. --> ## Current Behavior <!-- This is the behavior we have today --> Currently, `playwright` uses the `vite serve` command when setting up the web server to run the e2e tests against. The `vite preview` command/target should also depend on `vite build`. ## Expected Behavior <!-- This is the behavior we should expect with the changes in this PR --> `playwright` should use the `vite preview` command when setting up the web server `vite preview` targets add a `dependsOn["build"]` Ensure `serve-static` has a dependsOn: ['build'] Cypress should use the `ciBaseUrl` if it exists when running the `e2e-ci` targets Migrations for Playwright and Cypress to use serve-static and preview correctly ## Related Issue(s) <!-- Please link the issue being fixed so it gets closed when this is merged. --> Fixes #
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
Currently,
playwrightuses thevite servecommand when setting up the web server to run the e2e tests against.The
vite previewcommand/target should also depend onvite build.Expected Behavior
playwrightshould use thevite previewcommand when setting up the web servervite previewtargets add adependsOn["build"]Ensure
serve-statichas a dependsOn: ['build']Cypress should use the
ciBaseUrlif it exists when running thee2e-citargetsMigrations for Playwright and Cypress to use serve-static and preview correctly
Related Issue(s)
Fixes #