Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(release): do not add groups to commit message when their projects have no changes #27218

Merged
merged 1 commit into from
Jul 30, 2024

Conversation

JamesHenry
Copy link
Collaborator

Current Behavior

When using release groups and conventional commits or version plans, the group names can end up in the commit message even if their projects had no changes.

Expected Behavior

Release groups are only written to commit messages when their projects have changes.

Related Issue(s)

Fixes #

@JamesHenry JamesHenry requested a review from a team as a code owner July 30, 2024 19:35
@JamesHenry JamesHenry requested a review from Cammisuli July 30, 2024 19:35
Copy link

vercel bot commented Jul 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Jul 30, 2024 7:36pm

@JamesHenry JamesHenry enabled auto-merge (squash) July 30, 2024 19:35
@JamesHenry JamesHenry requested review from AgentEnder and removed request for Cammisuli July 30, 2024 19:36
@JamesHenry JamesHenry merged commit 8c88968 into master Jul 30, 2024
6 checks passed
@JamesHenry JamesHenry deleted the commit-null-group-version-fix branch July 30, 2024 20:27
FrozenPandaz pushed a commit that referenced this pull request Jul 30, 2024
Copy link

github-actions bot commented Aug 5, 2024

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants