feat(misc): add onboarding a/b testing #27217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FrozenPandaz
requested review from
a team,
vsavkin,
AgentEnder,
jaysoo and
JamesHenry
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 39cfd00. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 4 targets
Sent with 💌 from NxCloud. |
FrozenPandaz
force-pushed
the
success-ab
branch
2 times, most recently
from
18bdbef to
ac02137
Compare
| } | ||
|
|
||
| const { connectCloudUrl, output } = await getOnboardingInfo( |
There was a problem hiding this comment.
should we short-circuit this if the token is invalid?
Like for example not having an internet connection?
There was a problem hiding this comment.
If there's an error getting the token because of internet issues, then the process will exit 1 without reaching this part. So that short circuits this logic.
ndcunningham
approved these changes
Jul 30, 2024
FrozenPandaz
added a commit
that referenced
this pull request
Jul 30, 2024
<!-- Please make sure you have read the submission guidelines before posting an PR --> <!-- https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr --> <!-- Please make sure that your commit message follows our format --> <!-- Example: `fix(nx): must begin with lowercase` --> <!-- If this is a particularly complex change or feature addition, you can request a dedicated Nx release for this pull request branch. Mention someone from the Nx team or the `@nrwl/nx-pipelines-reviewers` and they will confirm if the PR warrants its own release for testing purposes, and generate it for you if appropriate. --> ## Current Behavior <!-- This is the behavior we have today --> The onboarding message during `create-nx-workspace` is not ideal. ## Expected Behavior <!-- This is the behavior we should expect with the changes in this PR --> We are A/b testing some options for the `create-nx-workspace` onboarding message. ## Related Issue(s) <!-- Please link the issue being fixed so it gets closed when this is merged. --> Fixes # (cherry picked from commit 341f295)
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
The onboarding message during
create-nx-workspaceis not ideal.Expected Behavior
We are A/b testing some options for the
create-nx-workspaceonboarding message.Related Issue(s)
Fixes #