Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nx-dev): clean up heading text #27205

Merged
merged 2 commits into from
Aug 6, 2024

Conversation

mandarini
Copy link
Member

@mandarini mandarini commented Jul 30, 2024

Fixing 3 issues when storing the page sections:

  1. The heading of a node can be like this: title: 'Angular Monorepo Tutorial - Part 1: Code Generation' description: In this tutorial you'll create a frontend-focused workspace with Nx. We only want to keep the title part.
  2. Some headings have {% highlightColor="green" %}. We want to remove that from the heading of the page section (and the link text)
  3. There's an error in tags.json where the path is incorrect. We want to fix that on the fly, so that the embeddings script finds the correct pages.

Copy link

vercel bot commented Jul 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview Aug 5, 2024 2:36pm

@mandarini mandarini force-pushed the fix/chat-references branch 2 times, most recently from d6c6b83 to d8ae80d Compare July 30, 2024 13:12
@mandarini mandarini marked this pull request as ready for review July 30, 2024 13:13
@mandarini mandarini self-assigned this Jul 30, 2024
@mandarini mandarini force-pushed the fix/chat-references branch from d8ae80d to 232c578 Compare July 31, 2024 12:41
@mandarini mandarini force-pushed the fix/chat-references branch from 232c578 to 300e0ad Compare August 5, 2024 14:28
@mandarini mandarini requested review from a team as code owners August 5, 2024 14:28
@mandarini mandarini requested a review from FrozenPandaz August 5, 2024 14:28
@mandarini
Copy link
Member Author

@FrozenPandaz done, updated!

@FrozenPandaz FrozenPandaz merged commit 720681f into nrwl:master Aug 6, 2024
6 checks passed
FrozenPandaz pushed a commit that referenced this pull request Aug 7, 2024
Fixing 3 issues when storing the page sections:

1. The heading of a node can be like this: `title: 'Angular Monorepo
Tutorial - Part 1: Code Generation' description: In this tutorial you'll
create a frontend-focused workspace with Nx`. We only want to keep the
`title` part.
2. Some headings have `{% highlightColor="green" %}`. We want to remove
that from the heading of the page section (and the link text)
3. There's an [error in `tags.json` where the path is
incorrect](https://github.com/nrwl/nx/blob/master/docs/generated/manifests/tags.json#L126).
We want to fix that on the fly, so that the embeddings script finds the
correct pages.

(cherry picked from commit 720681f)
ZackDeRose pushed a commit to ZackDeRose/nx that referenced this pull request Aug 8, 2024
Fixing 3 issues when storing the page sections:

1. The heading of a node can be like this: `title: 'Angular Monorepo
Tutorial - Part 1: Code Generation' description: In this tutorial you'll
create a frontend-focused workspace with Nx`. We only want to keep the
`title` part.
2. Some headings have `{% highlightColor="green" %}`. We want to remove
that from the heading of the page section (and the link text)
3. There's an [error in `tags.json` where the path is
incorrect](https://github.com/nrwl/nx/blob/master/docs/generated/manifests/tags.json#L126).
We want to fix that on the fly, so that the embeddings script finds the
correct pages.
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants