-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(nx-dev): clean up heading text #27205
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 300e0ad. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 4 targets
Sent with 💌 from NxCloud. |
d6c6b83
to
d8ae80d
Compare
d8ae80d
to
232c578
Compare
232c578
to
300e0ad
Compare
@FrozenPandaz done, updated! |
Fixing 3 issues when storing the page sections: 1. The heading of a node can be like this: `title: 'Angular Monorepo Tutorial - Part 1: Code Generation' description: In this tutorial you'll create a frontend-focused workspace with Nx`. We only want to keep the `title` part. 2. Some headings have `{% highlightColor="green" %}`. We want to remove that from the heading of the page section (and the link text) 3. There's an [error in `tags.json` where the path is incorrect](https://github.com/nrwl/nx/blob/master/docs/generated/manifests/tags.json#L126). We want to fix that on the fly, so that the embeddings script finds the correct pages. (cherry picked from commit 720681f)
Fixing 3 issues when storing the page sections: 1. The heading of a node can be like this: `title: 'Angular Monorepo Tutorial - Part 1: Code Generation' description: In this tutorial you'll create a frontend-focused workspace with Nx`. We only want to keep the `title` part. 2. Some headings have `{% highlightColor="green" %}`. We want to remove that from the heading of the page section (and the link text) 3. There's an [error in `tags.json` where the path is incorrect](https://github.com/nrwl/nx/blob/master/docs/generated/manifests/tags.json#L126). We want to fix that on the fly, so that the embeddings script finds the correct pages.
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Fixing 3 issues when storing the page sections:
title: 'Angular Monorepo Tutorial - Part 1: Code Generation' description: In this tutorial you'll create a frontend-focused workspace with Nx
. We only want to keep thetitle
part.{% highlightColor="green" %}
. We want to remove that from the heading of the page section (and the link text)tags.json
where the path is incorrect. We want to fix that on the fly, so that the embeddings script finds the correct pages.