fix(nx-dev): OG image meta tag #27195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 438e070. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 4 targets
Sent with 💌 from NxCloud. |
ndcunningham
force-pushed
the
fix/og-image-ai-blog
branch
from
1308417 to
b6956e2
Compare
ndcunningham
force-pushed
the
fix/og-image-ai-blog
branch
from
b6956e2 to
681c743
Compare
ndcunningham
force-pushed
the
fix/og-image-ai-blog
branch
2 times, most recently
from
196558b to
d867c92
Compare
ndcunningham
force-pushed
the
fix/og-image-ai-blog
branch
2 times, most recently
from
9037206 to
c7c669f
Compare
ndcunningham
force-pushed
the
fix/og-image-ai-blog
branch
from
c7c669f to
438e070
Compare
juristr
reviewed
Jul 31, 2024
| image: imagePath.replace(ext, foundExt), | ||
| type: foundExt.replace('.', ''), | ||
| }; | ||
| } |
There was a problem hiding this comment.
nit: for code readability I prefer an else here to see the two options
juristr
reviewed
Jul 31, 2024
| const { ext } = parse(imagePath); | ||
|
|
||
| if (!allowedExtensions.includes(ext)) { | ||
| const foundExt = allowedExtensions.find((allowedExt) => { |
There was a problem hiding this comment.
I'd love if this at some point would automatically run a conversion. But this def works for now
juristr
approved these changes
Jul 31, 2024
FrozenPandaz
pushed a commit
that referenced
this pull request
Aug 1, 2024
(cherry picked from commit edf0651)
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR defaults the OG image if one of the correct file types is not provided.