Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(release): ensure @org/package style names are wrapped in quotes in version plans #27177

Merged
merged 1 commit into from
Jul 30, 2024

Conversation

JamesHenry
Copy link
Collaborator

Current Behavior

Version plans created via the nx CLI do not wrap @org/package style names in quotes, causing parsing issues at versioning time.

Expected Behavior

@org/package style names are generated with surrounding quotes and there are no parsing issues at versioning time.

Related Issue(s)

Fixes #27010

@JamesHenry JamesHenry requested a review from a team as a code owner July 29, 2024 09:38
@JamesHenry JamesHenry requested a review from FrozenPandaz July 29, 2024 09:38
Copy link

vercel bot commented Jul 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Jul 29, 2024 9:39am

@JamesHenry JamesHenry changed the title fix(release): ensure @org/package style names are wrapped in quotes in plans files fix(release): ensure @org/package style names are wrapped in quotes in version plans Jul 29, 2024
@JamesHenry JamesHenry enabled auto-merge (squash) July 29, 2024 09:38
@JamesHenry JamesHenry merged commit 17c87a5 into master Jul 30, 2024
6 checks passed
@JamesHenry JamesHenry deleted the fix/27010 branch July 30, 2024 18:04
FrozenPandaz pushed a commit that referenced this pull request Jul 30, 2024
Copy link

github-actions bot commented Aug 5, 2024

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nx release plan with a project containing a scoped npm package, and no project name creates a malformed plan
2 participants