fix(webpack): include hash in asset filenames so they do not conflict #27159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit df73778. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 4 targets
Sent with 💌 from NxCloud. |
packages/webpack/src/plugins/nx-webpack-plugin/lib/apply-web-config.ts
Outdated
Show resolved
Hide resolved
ndcunningham
approved these changes
Jul 26, 2024
FrozenPandaz
pushed a commit
that referenced
this pull request
Jul 30, 2024
…#27159) Our assets are generated as flat assets in dist, which allows using assets from workspace libs. This prevents users from having different assets with the same filename (e.g. `foo/image.png` and `bar/image.png`). This will error out in the dev server with conflicting filenames. We cannot use `[path][name]` because of assets that are outside of the app folder (e.g. `../../libs/ui/src/assets/image.png`). Thus the best option is to include hash. Note: Also re-enabled the e2e tests for `react.test.ts` file since it is now using Playwright instead of Cypress. ## Current Behavior Assets with the same filename will error in dev-mode. ## Expected Behavior Assets with the same filename works. ## Related Issue(s) <!-- Please link the issue being fixed so it gets closed when this is merged. --> Fixes #18272 (cherry picked from commit 0710fea)
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our assets are generated as flat assets in dist, which allows using assets from workspace libs. This prevents users from having different assets with the same filename (e.g.
foo/image.pngandbar/image.png). This will error out in the dev server with conflicting filenames.We cannot use
[path][name]because of assets that are outside of the app folder (e.g.../../libs/ui/src/assets/image.png). Thus the best option is to include hash.Note: Also re-enabled the e2e tests for
react.test.tsfile since it is now using Playwright instead of Cypress.Current Behavior
Assets with the same filename will error in dev-mode.
Expected Behavior
Assets with the same filename works.
Related Issue(s)
Fixes #18272