feat(devkit): allow updating package json based projects #27138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 04cf256. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 4 targets
Sent with 💌 from NxCloud. |
AgentEnder
force-pushed
the
feat/package-json-generators
branch
from
18d8879 to
04cf256
Compare
FrozenPandaz
requested changes
Jul 26, 2024
|
|
||
| const packageJson = readJson<PackageJson>(tree, packageJsonFile); | ||
|
|
||
| if (packageJson.name === projectConfiguration.name ?? projectName) { |
There was a problem hiding this comment.
If the name is not equal, what do we do? Do we set it in package.json#name or do we set it in package.json#nx.name?
There was a problem hiding this comment.
nx.name, setting package.json name could break a published package
FrozenPandaz
approved these changes
Jul 26, 2024
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
Calling
updateProjectConfigurationon a package json based project failsExpected Behavior
Calling
updateProjectConfigurationon a package json based project worksRelated Issue(s)
Fixes #26530