feat(core): add --exclude-task-dependencies flag #27137
Merged
+115
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 900ad3d. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 4 targets
Sent with 💌 from NxCloud. |
isaacplmann
previously requested changes
Jul 26, 2024
| @@ -79,6 +80,12 @@ export function withRunOptions<T>(yargs: Argv<T>): Argv<T & RunOptions> { | |||
| type: 'boolean', | |||
| default: false, | |||
| }) | |||
| .options('noDependencies', { | |||
| describe: 'Skips running dependant tasks first', | |||
There was a problem hiding this comment.
Suggested change
| describe: 'Skips running dependant tasks first', | |
| describe: 'Skips running dependent tasks first', |
FrozenPandaz
requested changes
Jul 26, 2024
| @@ -32,7 +32,7 @@ export async function affected( | |||
| (TargetDependencyConfig | string)[] | |||
| > = {}, | |||
| extraOptions = { | |||
| excludeTaskDependencies: false, | |||
| excludeTaskDependencies: args.noDependencies, | |||
There was a problem hiding this comment.
Let's change the arg to --exclude-task-dependencies
FrozenPandaz
changed the title
FrozenPandaz
approved these changes
Jul 26, 2024
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
There is no option to exclude dependent tasks when running Nx.
Expected Behavior
There is a flag,
--exclude-task-dependencies, to exclude task deps from running. This is inline with other tools:Related Issue(s)
Fixes #18053